engine: 29.7.0 - #25662
Draft
vvoland wants to merge 2 commits into
Draft
Conversation
The second grep exits after finding the next release heading, which can close the pipe while the first grep is still writing. With pipefail, that SIGPIPE is reported as if the requested release notes were missing. Read the release file directly with awk and stop at the next level-two heading so early termination cannot fail an upstream process. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
area/engine
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
One typo found in the 29.7.0 release notes. The shell script change in hack/moby-sync-release.sh looks correct. The hugo.yaml update is clean.
|
|
||
| - Add the `default-stop-timeout` daemon option to configure the stop timeout assigned to containers without an explicit timeout. [moby/moby#53146](https://github.com/moby/moby/pull/53146) | ||
| - containerd image store: Fix daemon-wide concurrent download and upload limits for pulls and pushes not being honored. [moby/moby#53081](https://github.com/moby/moby/pull/53081) | ||
| - To preserve the previous unlimited startup behavior, configure "max-concurrent-downloads" and ""max-concurrent-uploads" to 0 |
Contributor
There was a problem hiding this comment.
[MEDIUM] Doubled double-quote typo in daemon option name ""max-concurrent-uploads"
The line reads:
configure "max-concurrent-downloads" and ""max-concurrent-uploads" to 0
The option ""max-concurrent-uploads" has an extra leading double-quote. It should be "max-concurrent-uploads" to match the formatting of the first option. Users copying this literally would pass a malformed option name to the daemon configuration.
Suggested fix:
configure "max-concurrent-downloads" and "max-concurrent-uploads" to 0
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Release notes for Docker Engine 29.7.0-rc.1. Found one confirmed typo and a heading/milestone consistency issue to address.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
marked this pull request as draft
July 28, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews